feat(kernel-browser-runtime): add slot-based UIOrchestrator #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirtimid
changed the title
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sirtimid
commented
Feb 5, 2026
| title?: string, | ||
| visible = true, | ||
| ): HTMLIFrameElement { | ||
| const iframe = document.createElement('iframe'); |
Contributor
Author
There was a problem hiding this comment.
Should we use createWindow from @metamask/snaps-utils? But UIOrchestrator needs the iframe element itself for lifecycle management
…ed orchestration Add UIOrchestrator for managing visible UI vat iframes in named slots, enabling multiple caplet UIs to coexist in a structured layout. - Add UIOrchestrator class with slot-based iframe management - Add makeUIVatWorker factory for VatWorker interface - Add <div id="root"> mounting point to vat/iframe.html - Export SlotName type (currently 'main', extensible) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Create logger once at construction time in makeUIVatWorker instead of per method call - Track in-progress launches to prevent concurrent launches with same ID from orphaning iframes - Clean up iframe from DOM when connection establishment fails Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ion error handling - Save original document.createElement before mocking to prevent infinite recursion when creating non-iframe elements in tests - Move iframe creation inside try block so ID is removed from launchesInProgress if createIframe throws Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…rminateAll Use Array.from() to snapshot uiVats keys before iterating, consistent with the pattern in PlatformServicesServer.ts. Prevents potential issues from map modification during iteration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sirtimid
force-pushed
the
sirtimid/ui-vat-infrastructure
branch
from
eec21e3 to
4daeb57
Compare
…ent launch prevention Cover the iframe load error cleanup path (remove iframe, clear launchesInProgress, allow retry) and the concurrent launch guard that rejects duplicate IDs while a launch is in progress. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| */ | ||
| getSlotNames(): SlotName[] { | ||
| return Object.keys(this.#slots) as SlotName[]; | ||
| } |
There was a problem hiding this comment.
Unsafe type cast in getSlotNames returns misleading type
Low Severity
The getSlotNames() method uses an unsafe cast as SlotName[] which creates a type mismatch when the orchestrator is configured with extra slots beyond 'main'. The slots object can accept additional properties like 'sidebar' (as demonstrated in the test at line 627-628), but Object.keys() returns all keys while the return type claims it's only ('main')[]. This type lie could mislead consumers who rely on TypeScript to understand the possible return values. The PR description mentions SlotName is "extensible", but the current type design doesn't support extension without unsafe casting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
UIOrchestratorfor managing visible UI vat iframes in named slots, enabling multiple caplet UIs to coexist in a structured layout.UIOrchestratorclass with slot-based iframe managementmakeUIVatWorkerfactory forVatWorkerinterface<div id="root">mounting point tovat/iframe.htmlSlotNametype (currently'main', extensible)Usage
Architecture
Test plan
UIOrchestrator(slot management, lifecycle, etc.)🤖 Generated with Claude Code
Note
Medium Risk
Introduces new iframe creation/sandboxing and cross-window messaging setup; mistakes here could affect UI isolation or messaging reliability, though the change is largely additive and covered by unit tests.
Overview
Adds a new slot-based UI iframe lifecycle manager via
UIOrchestrator, which can launch sandboxed UI-vat iframes, establish aMessagePortconnection, track them by id/slot, and provide show/hide/terminate APIs (including cleanup on failed loads and protection against concurrent duplicate launches).Introduces
makeUIVatWorkerto expose UI vats through the existingVatWorkerinterface, exports the new UI surface from the package entrypoint, and updates the vat iframe template to include a#rootmount point. Comprehensive unit tests are added forUIOrchestrator, andindex.test.tsis updated to assert the new exports.Written by Cursor Bugbot for commit fa096ce. This will update automatically on new commits. Configure here.